Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #146 by ensuring that route URL concatenations correctly handle trailing slashes in the virtual path root. The changes update authentication paths, controller routes, and file server request paths to conditionally insert a slash if needed.
- Updated login and access denied paths in ServiceCollectionExtensions.cs.
- Modified controller route paths and file server request path in ApplicationBuilderExtensions.cs.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/SilkierQuartz/Configuration/ServiceCollectionExtensions.cs | Adjusts authentication route paths for correct URL formatting. |
| src/SilkierQuartz/Configuration/ApplicationBuilderExtensions.cs | Updates controller routes and file server path for consistent URL construction. |
Comments suppressed due to low confidence (2)
src/SilkierQuartz/Configuration/ServiceCollectionExtensions.cs:44
- [nitpick] The logic for conditionally appending a slash is repeated; consider extracting it into a helper method to improve maintainability and reduce duplication.
cfg.LoginPath = "${options.VirtualPathRoot}{(options.VirtualPathRoot.EndsWith('/') ? "" : "/")}Authenticate/Login";
src/SilkierQuartz/Configuration/ApplicationBuilderExtensions.cs:91
- [nitpick] The conditional logic for ensuring the correct separator is repeated; extracting this logic into a shared utility could enhance code clarity and maintainability.
endpoints.MapControllerRoute(nameof(SilkierQuartz), "${options.VirtualPathRoot}{(options.VirtualPathRoot.EndsWith('/')?"":"/")}{controller=Scheduler}/{action=Index}");
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.